Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pdb validation bug on spec #48706

Merged
merged 1 commit into from
Jul 28, 2017
Merged

fix pdb validation bug on spec #48706

merged 1 commit into from
Jul 28, 2017

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Jul 10, 2017 •
edited

What this PR does / why we need it:

When working on issue #48691, I found a bug on current pdb validation on spec. This validation is to check PodDisruptionBudgetSpec instead of the whole obj. Currently when doing updates, this check will fail as always.

Which issue this PR fixes : fix #48691

Special notes for your reviewer:

Release note:

fix pdb validation bug on PodDisruptionBudgetSpec

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 10, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 10, 2017
@lukaszo
Copy link
Contributor

lukaszo commented Jul 11, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 11, 2017
@lukaszo
Copy link
Contributor

lukaszo commented Jul 11, 2017

@dixudx Please add unit test for this case

@fejta
Copy link
Contributor

fejta commented Jul 11, 2017

/test pull-kubernetes-e2e-kops-aws

@dixudx dixudx force-pushed the fix_bug_validating_pdb_spec branch from 36bc5e5 to edeea36 Compare July 12, 2017 08:46
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2017
@dixudx
Copy link
Member Author

dixudx commented Jul 12, 2017

@lukaszo Tests added. Need your approval. Thx.

gyliu513
gyliu513 reviewed Jul 12, 2017
View reviewed changes
Copy link
Contributor

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2017
@lukaszo
Copy link
Contributor

lukaszo commented Jul 12, 2017

/approve

@dixudx
Copy link
Member Author

dixudx commented Jul 12, 2017

/assign @smarterclayton

@dixudx
Copy link
Member Author

dixudx commented Jul 24, 2017

@smarterclayton Need your approval. Thanks so much.

@lukaszo
Copy link
Contributor

lukaszo commented Jul 25, 2017

@Kargakis can you approve? It seems @smarterclayton is too busy

@0xmichalis
Copy link
Contributor

Only sig-apps-api-approvers can. We also need to cherry-pick this back to 1.7 and maybe 1.6?

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@0xmichalis 0xmichalis added this to the v1.7 milestone Jul 25, 2017
@lukaszo
Copy link
Contributor

lukaszo commented Jul 25, 2017

Oh, I assumed that you are in that group. Sorry
Ping @erictune @smarterclayton

@smarterclayton
Copy link
Contributor

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, gyliu513, lukaszo, smarterclayton

Associated issue: 48691

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2017
@fejta
Copy link
Contributor

fejta commented Jul 27, 2017

/retest
Failure was caused by #49679

@dixudx
Copy link
Member Author

dixudx commented Jul 27, 2017

/test pull-kubernetes-kubemark-e2e-gce

@dixudx
Copy link
Member Author

dixudx commented Jul 27, 2017

/test pull-kubernetes-e2e-gce-etcd3

@fejta-bot
Copy link

/retest
Automated flake /retester experiment. Please send feedback to fejta

@dixudx
Copy link
Member Author

dixudx commented Jul 28, 2017

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit a50b3a9 into kubernetes:master Jul 28, 2017
This was referenced Jul 28, 2017
Closed
Closed
@wojtek-t wojtek-t mentioned this pull request Jul 28, 2017
Merged
@wojtek-t
Copy link
Member

Cherrypick approved

@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 28, 2017
@dixudx dixudx deleted the fix_bug_validating_pdb_spec branch July 28, 2017 08:32
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

1 similar comment
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

k8s-github-robot pushed a commit that referenced this pull request Aug 2, 2017
Merge pull request #49768 from wojtek-t/automated-cherry-pick-of-#487…
0c4af4e 
…06-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #48706 upstream release 1.7

Cherry pick of #48706 on release-1.7.

#48706: fix pdb validation bug on spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyliu513 gyliu513 gyliu513 left review comments

Assignees

@lukaszo lukaszo

@smarterclayton smarterclayton

@gyliu513 gyliu513

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

kubectl force apply SIGSEGV with podDistributionBudgets